723419 - chmod 644 MD5/SHA1/SHA512 files

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

Attachment: chmod checksums

checksums builder doesn't set chmod of generated files explicitly what causes permission check failure:

https://wiki.mozilla.org/Releases/Firefox_11.0b1/BuildNotes#Permission_check

subprocess.CalledProcessError: Command '['ssh', '-l', 'ffxbld', '-i', '/Users/cltbld/.ssh/ffxbld_dsa', 'stage.mozilla.org', 'test "0" = "$(find /pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/ -type f ! -perm 644 | wc -l)"']' returned non-zero exit status 1

Manual check:

find /pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/ -type f ! -perm 644
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/KEY
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/MD5SUMS
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/MD5SUMS.asc
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/SHA1SUMS
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/SHA1SUMS.asc
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/SHA512SUMS
/pub/mozilla.org/firefox/nightly/11.0b1-candidates/build1/SHA512SUMS.asc

umask is set to 0002 on the build slaves what causes default chmod 664 for regular files.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 593737 [details] [diff] [review]
chmod checksums

Review of attachment 593737 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/release/generate-sums.py
@@ +83,5 @@
>      files = types.values()
>      signFiles(files)
>      upload_files = files + ['%s.asc' % x for x in files] + \
>          [path.join(path.dirname(__file__), 'KEY')]
> +    run_cmd(['chmod', '644'] + upload_files)

Any reason not to use os.chmod here?

Comment 2

[Rail Aliiev [:rail]]

Attachment: fix permissions using os.chmod

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 594189 [details] [diff] [review]
fix permissions using os.chmod

http://hg.mozilla.org/build/tools/rev/5aaaadaede8f

Comment 4

[[e-mail] (:bhearsum)]

I think we need to use a leading zero, actually. We got weird permissions in 11.0b2:
--w----r-T  1 cltbld cltbld 196984 Feb  8 09:30 SHA1SUMS

Comment 5

[[e-mail] (:bhearsum)]

I landed a bustage fix, and it stuck: http://hg.mozilla.org/build/tools/rev/85e53fbfb24a